search

cozy / cozy-banks

A Banks Aggregator on Cozy
https://cozy.io
GNU Affero General Public License v3.0
59 stars 26 forks source link

[VO-400] fix: Show konnector error on transaction list #2700

Closed cballevre closed 7 months ago

cballevre commented 7 months ago 
### 🐛 Bug Fixes

* Show konnector error on transaction list

isBankTrigger didn't have the bankingSlug when it was run with the HOC. As the function with bankingSlug is also exposed via a context, so I chose this way. There's also the advantage of having one less request because you don't have to execute the hook several times.

bundlemon[bot] commented 7 months ago

BundleMon

Unchanged files (44) Status | Path | Size | Limits :------------: | ------------ | :------------: | :------------: :white_check_mark: | screenshots/fr/screenshot4.png
| 1.29MB | - :white_check_mark: | screenshots/en/screenshot4.png
| 1.28MB | - :white_check_mark: | screenshots/fr/screenshot5.png
| 1.17MB | - :white_check_mark: | screenshots/en/screenshot5.png
| 1.17MB | - :white_check_mark: | services/categorization/banks.js
| 1.13MB | - :white_check_mark: | services/onOperationOrBillCreate/banks.js
| 1018.63KB | - :white_check_mark: | services/recurrence/banks.js
| 1005.12KB | - :white_check_mark: | services/konnectorAlerts/banks.js
| 1003.89KB | - :white_check_mark: | services/budgetAlerts/banks.js
| 982.93KB | - :white_check_mark: | services/autogroups/banks.js
| 446.26KB | - :white_check_mark: | services/linkMyselfToAccounts/banks.js
| 445.73KB | - :white_check_mark: | screenshots/fr/screenshot1.png
| 330.32KB | - :white_check_mark: | screenshots/en/screenshot1.png
| 311.39KB | - :white_check_mark: | screenshots/fr/screenshot2.png
| 264.27KB | - :white_check_mark: | screenshots/en/screenshot2.png
| 256.24KB | - :white_check_mark: | screenshots/fr/screenshot3.png
| 246.98KB | - :white_check_mark: | screenshots/en/screenshot3.png
| 243.76KB | - :white_check_mark: | img/veepee-info.43d778410d97b8e73b4eb07bb4631
d74.png
| 173.24KB | - :white_check_mark: | img/veepee-info@2x.e00642b6164d2b110ebd6a1443
9fcda5.png
| 167.13KB | - :white_check_mark: | img/ameli-side.7173251188c5fe0d8d54e265f8426a
89.png
| 115.29KB | - :white_check_mark: | vendors-banks.(hash).(hash).min.css
| 28.28KB | - :white_check_mark: | img/veepee.9d3db3d18a5534582eba5b9fdbddb8bf.p
ng
| 25.01KB | - :white_check_mark: | img/transfer-error.81739cda73db9309b4f58bf975
ee3856.jpg
| 24.69KB | - :white_check_mark: | img/transfer-done.952c792c91ee5a8b70e025e85bf
4938a.jpg
| 13.95KB | - :white_check_mark: | 83ef4de322a6ddf7034d4b1366d1c9fe.png
| 9.59KB | - :white_check_mark: | icon-banks.jpg
| 8.09KB | - :white_check_mark: | img/search-illu.4536cb0962f2010e397bb96aeed5b
415.svg
| 4.48KB | - :white_check_mark: | img/timeline_desktop_fr.8a2f9796b9d34fdc21eec
489d2f16db1.svg
| 3.94KB | - :white_check_mark: | img/timeline_mobile_fr.e42a3b60dcefcdbae40e44
9c49c01d83.svg
| 3.83KB | - :white_check_mark: | img/timeline_mobile_en.0f4ace6755128e27a825e0
31b0480a71.svg
| 3.66KB | - :white_check_mark: | img/timeline_desktop_en.8ed0e7248216da5fb042e
30314036a39.svg
| 3.51KB | - :white_check_mark: | mesinfos/favicon-32x32.png
| 1.39KB | - :white_check_mark: | mesinfos/favicon.ico
| 1.19KB | - :white_check_mark: | mesinfos/favicon-16x16.png
| 1.11KB | - :white_check_mark: | img/NoAccount.5cd307dbe22ac700d2f570f2c33487e
3.svg
| 1021B | - :white_check_mark: | mesinfos/icon-bank.svg
| 645B | - :white_check_mark: | index.html
| 524B | - :white_check_mark: | img/pie-demo.5d713502666ac766dddccd37e34b0089
.svg
| 449B | - :white_check_mark: | 8751e4271e335d10b8e2d7ca83837d1b.png
| 322B | - :white_check_mark: | bfca87187b6aff074f409395499acc1e.png
| 311B | - :white_check_mark: | favicon-32x32.png
| 242B | - :white_check_mark: | public/safari-pinned-tab.svg
| 229B | - :white_check_mark: | favicon-16x16.png
| 216B | - :white_check_mark: | icon-banks.svg
| 188B | -

Total files change -2B 0%

Groups updated (1) Status | Path | Size | Limits :------------: | ------------ | :------------: | :------------: :white_check_mark: | app/**
| 194.82KB (+14B +0.01%) | -
Unchanged groups (3) Status | Path | Size | Limits :------------: | ------------ | :------------: | :------------: :white_check_mark: | services/**
| 8.2MB | - :white_check_mark: | vendors/**
| 1.53MB | - :white_check_mark: | img/**
| 540.16KB | -

Final result: :white_check_mark:

View report in BundleMon website ➡️

Current branch size history | Target branch size history

cballevre commented 7 months ago

@Ldoppea Yes, the problem was that the component didn't render after the bankingSlug list reference change in the function (code). The problem is that the component is memoised for performance reasons. Its parent is re-rendered each time it is modified in the cozy-client redux store as a side effect. Using a context gets around this problem.

I've chosen not to rework the PersonalInfoDialog component because it isn't memoised and it's part of a feature that hasn't been released for a long time: transfers.