search

cozy / cozy-browser-sdk

Cozy Data System client for the browser
http://dev.cozy.io
MIT License
7 stars 12 forks source link

Fix npmignore #10

Closed m4dz closed 8 years ago

m4dz commented 8 years ago

The PR removes dist folder from npmignore. Currenlty, when retrieved via npm/gh, the package doesn't contain the lib :disappointed:

frankrousseau commented 8 years ago

Published as 0.0.3

m4dz commented 8 years ago

\o/ Thanks!

aenario commented 8 years ago

The dist files were browserified to be included through <script> whereas the lib file were require-able node modules.

There may be a build issue with the lib file, but the npm package shold include only lib and not dist

frankrousseau commented 8 years ago

@aenario can you find a consensus with @m4dz and apply the fixes ?

m4dz commented 8 years ago

@aenario I think you're good, even if the dist output fil also contains the commonjs logics. Seems OK to me if we keep the lib generated folder along the dist folder.