search

cozy / cozy-calendar

An application to manage your events
https://demo.cozycloud.cc/#apps/calendar/
GNU Affero General Public License v3.0
66 stars 39 forks source link

Fix calendar without color #566

Closed gregorylegarec closed 8 years ago

gregorylegarec commented 8 years ago

As we are going to use a model object for calendar instead of refering it as a Tag, this issue was the good opportunity to finally create a Calendar class. At this time, it only inherit from Tag and ad an empty color detection.

It allows to avoid some be UI issues when a calendar color is not set.

This change implies some little updates in CalendarColleciton class.

nono commented 8 years ago

@gregorylegarec can you look at the comments?

gregorylegarec commented 8 years ago

@nono Yep sorry, I missed them.

gregorylegarec commented 8 years ago

@frankrousseau I will clarify the code right now and add a "color check" in a success callback too. I'll ping you when it's done.

frankrousseau commented 8 years ago

Ok sounds great!

gregorylegarec commented 8 years ago

Finally fixed. Sorry it took me so much time since friday : first lunch break, then meeting with Benjamin, medical examination, journey back to Rouen and finally I have been busy all the week-end.