Debug list - Githubissues

cozy / cozy-clearance

Clearance manager for cozy apps

Other

2 stars 7 forks source link

Debug list #13

Open frankrousseau opened 10 years ago

frankrousseau commented 10 years ago

Hi,

I met several problems that should be fixed or at least mentioned in the documentation:

Translations are not there by default
The modal requires to be extended that way:

class ShareModal extends CozyClearanceModal
    initialize: ->
        super
        @refresh()

The model should have a .getPublicUrl method (on server side too).
The model requires two attributes: clearance and type (on server side too).

@model.set 'clearance', []
@model.set 'type', 'album'

jsilvestre commented 10 years ago

The end of your post is missing.

aenario commented 9 years ago

Also :

when the user press escape, the event close the modal but then bubble up. We should e.preventDefault() in closeOnEscape.

Actually, its more complicated than that, because the modal add its listener on the document after the app, so if the app also listen for key event, it will trigger first. We need to listen on the modal container and make it focusable with tabIndex, then we need to maintain the focus in the modal. Ref : https://github.com/jquery/jquery-ui/blob/d58051ba1a7d06b503853645b13babfc9d8a0242/ui/dialog.js#L346

Note : this is for projects using the cozy-clearance/modal for other purpose (like photos & contacts photos-from-file feature)