[VO-874] feat: Improve index naming

[cballevre]

Index naming has two weaknesses:

• it doesn't include partial index values

This can cause differences between the expected result and the result when modifying queries.

An example of the new index name:

Query definition :

Q('io.cozy.files')
  .where({
    type: 'file',
  })
  .partialIndex({
    class: {
      $or: ['image', 'pdf'] 
    }
    trashed: {
      $eq: false 
    }
  })
  .sortBy([
    { name: 'desc' }
  ])

Old index name : _design/by_type_and_name_filter_class_and_trashed New index name : _design/by_type_and_name_filter_(class_(image_$or_pdf))_and_(trashed_$eq_false)

[paultranvan]

Related to https://github.com/cozy/cozy-client/issues/1374

[Crash--]

So much cleaner than what I did before 👏 👏

Since you have changed the index name, you're going to have a pretty heavy DB server load when you release an app with this (mainly app with services ;))

In fact you're just going to update the name of the index, it should be ok.

[paultranvan]

Since you have changed the index name, you're going to have a pretty heavy DB server load when you release an app with this (mainly app with services ;))

Since we migrate the existing index through a copy, we should avoid a too much consequent load (i.e. we don't recompute index)

[Crash--]

Yep, I updated my comment just before yours ;).

Just a last thing: I know that we had conflicts between the sack and cozy-client about index name. A few users had blank page because of this. I think that stack use partialFilters on some place, I'll double check that ;).

[paultranvan]

A few users had blank page because of this. I think that stack use partialFilters on some place, I'll double check that ;).

If you find any info about this, that would be precious!