Improve POSIX compatibility, add compatibility with Busybox

cozy / cozy-controller

Cozy Module and Apps deployer

cozy.io

GNU Affero General Public License v3.0

5 stars 13 forks source link

Improve POSIX compatibility, add compatibility with Busybox #147

Closed Batchyx closed 8 years ago

Batchyx commented 8 years ago

This removes the unneeded dependency on bash and removes the dependency on GNU coreutils because of a non-POSIX option. Then it adds supports for busybox's adduser applet.

This improves compatibility with POSIX systems not based on GNU, which is often the case in embedded systems where light alternatives like Busybox are preferred.

frankrousseau commented 8 years ago

Thank you @Batchyx for this nice PR. We'll review it very soon.

frankrousseau commented 8 years ago

Your first commit (about the user creation) breaks tests. Can you see what's wrong?

Batchyx commented 8 years ago

There were some bashisms left in adduser.sh, which busybox tolerates, but dash does not. It should be better now.

Batchyx commented 8 years ago

Apparently not. I'll investigate further...

frankrousseau commented 8 years ago

Thx @Batchyx

Batchyx commented 8 years ago

I expected that server/lib/adduser.sh would be copied to build/server/lib/adduser.sh, but it does not. In fact, those two files are already different in your tree.

nono commented 8 years ago

Oh, good catch! Thanks for the PR.