search

cozy / cozy-doctypes

The doctypes used in cozy-stack
https://docs.cozy.io/en/cozy-doctypes/docs/
GNU Affero General Public License v3.0
2 stars 29 forks source link

feat: Update io.cozy.contacts doctype #75

Closed cedricmessiant closed 5 years ago

cedricmessiant commented 5 years ago

Add cozyMetadata and accounts relationships to io.cozy.contacts doctype

cedricmessiant commented 5 years ago

@y-lohse good catch, thanks! Why to we use snake case here while for every other field we use camel case? Also, do you agree that all of the fields that I added are required?

y-lohse commented 5 years ago

Why to we use snake case here while for every other field we use camel case?

Good question, I think that might also be a mistake. last_sync and contacts_accounts_id should probably be camel-cased.

Also, do you agree that all of the fields that I added are required?

Yes, appart from the version field everything looks ok to me :). Well, that and the snake case now.

cedricmessiant commented 5 years ago

everything should be good now