cozy / cozy-drive

Cozy Drive Web App for Cozy Cloud
GNU Affero General Public License v3.0
171 stars 65 forks source link

[VO-149] refactor: Remove Cordova app #3058

Closed cballevre closed 10 months ago

cballevre commented 10 months ago
### 🔧 Tech

* Remove Cordova app

Why remove all this code? We are no longer publishing the Drive application via Cordova but through the flagship application. As it was dead code, we've decided to remove it to facilitate maintenance and the development of new functionality.

What does the PR do?

Remaining work:

Work for a next PR:

bundlemon[bot] commented 10 months ago

BundleMon

Files removed (1) Status | Path | Size | Limits :------------: | ------------ | :------------: | :------------: :white_check_mark: | drive/img/app-icon.(hash).svg
| -419B | -
Files updated (7) Status | Path | Size | Limits :------------: | ------------ | :------------: | :------------: :white_check_mark: | drive/intents/index.html
| 486B (-31B -6%) | 1KB :white_check_mark: | drive/intents/drive.(hash).js
| 105.88KB (-2.87KB -2.63%) | 190KB :white_check_mark: | drive/app-drive.(hash).min.css
| 40.97KB (-14.54KB -26.2%) | 56KB :white_check_mark: | drive/public/drive.(hash).min.css
| 76.3KB (-16.02KB -17.35%) | 100KB :white_check_mark: | drive/app/drive.(hash).js
| 167.27KB (-24.92KB -12.97%) | 300KB :white_check_mark: | drive/vendors/drive.(hash).js
| 1.53MB (-190.63KB -10.86%) | 2MB :white_check_mark: | drive/public/drive.(hash).js
| 1.32MB (-203.28KB -13.08%) | 1.7MB
Unchanged files (11) Status | Path | Size | Limits :------------: | ------------ | :------------: | :------------: :white_check_mark: | drive/public/pdf.worker.entry.(hash).worker.j
s
| 343.38KB | 345KB :white_check_mark: | drive/services/dacc/drive.js
| 261KB | 500KB :white_check_mark: | drive/services/qualificationMigration/drive.j
s
| 255.08KB | 500KB :white_check_mark: | drive/public/cozy-client-js.js
| 158.97KB | 160KB :white_check_mark: | drive/intents-drive.(hash).min.css
| 36.91KB | 40KB :white_check_mark: | drive/onlyOffice/slide.pptx
| 24.82KB | 25KB :white_check_mark: | drive/onlyOffice/text.docx
| 5.84KB | 6KB :white_check_mark: | drive/onlyOffice/spreadsheet.xlsx
| 5.01KB | 6KB :white_check_mark: | drive/manifest.webapp
| 1.9KB | 2KB :white_check_mark: | drive/index.html
| 531B | 1KB :white_check_mark: | drive/manifest.json
| 184B | 1KB

Total files change -452.69KB -9.33%

Groups updated (5) Status | Path | Size | Limits :------------: | ------------ | :------------: | :------------: :white_check_mark: | drive/img/**
| 3.41KB (-419B -10.72%) | - :white_check_mark: | drive/intents/**
| 106.35KB (-2.9KB -2.65%) | - :white_check_mark: | drive/app/**
| 167.27KB (-24.92KB -12.97%) | - :white_check_mark: | drive/vendors/**
| 1.53MB (-190.63KB -10.86%) | - :white_check_mark: | drive/public/**
| 1.9MB (-219.3KB -10.15%) | -
Unchanged groups (2) Status | Path | Size | Limits :------------: | ------------ | :------------: | :------------: :white_check_mark: | drive/services/**
| 516.08KB | - :white_check_mark: | drive/onlyOffice/**
| 35.68KB | -

Final result: :white_check_mark:

View report in BundleMon website ➡️


Current branch size history | Target branch size history

zatteo commented 10 months ago

Seems that we will also be able to do some cleaning on cozy-client ? https://github.com/cozy/cozy-client/blob/2ded95151510d0d9eddbdb585d8f860dce9240be/packages/cozy-client/src/models/fsnative.js#L145C5-L145C5

cballevre commented 10 months ago

Yep its planned but we need to remove Cordova into cozy-banks before

Crash-- commented 10 months ago

Yep its planned but we need to remove Cordova into cozy-banks before

I don't think that banks use cozy-client's cordova stuff?

But do in the order you want, the global removal is important, the path not so much for that one ;)