cozy / cozy-drive

Cozy Drive Web App for Cozy Cloud
GNU Affero General Public License v3.0
169 stars 65 forks source link

fix: Add AlertProvider to AddMenuProvider #3059

Closed acezard closed 8 months ago

acezard commented 8 months ago

🐛 Bug Fixes

cballevre commented 8 months ago

I suggest you add it here so that it will be available for all other add-ons in the future rather than specifically for the add menu.

bundlemon[bot] commented 8 months ago

BundleMon

Unchanged files (18) Status | Path | Size | Limits :------------: | ------------ | :------------: | :------------: :white_check_mark: | drive/vendors/drive.(hash).js
| 1.53MB | 2MB :white_check_mark: | drive/public/drive.(hash).js
| 1.32MB | 1.7MB :white_check_mark: | drive/public/pdf.worker.entry.(hash).worker.j
s
| 343.38KB | 345KB :white_check_mark: | drive/services/dacc/drive.js
| 261KB | 500KB :white_check_mark: | drive/services/qualificationMigration/drive.j
s
| 255.08KB | 500KB :white_check_mark: | drive/app/drive.(hash).js
| 167.28KB | 300KB :white_check_mark: | drive/public/cozy-client-js.js
| 158.97KB | 160KB :white_check_mark: | drive/intents/drive.(hash).js
| 105.88KB | 190KB :white_check_mark: | drive/public/drive.(hash).min.css
| 76.3KB | 100KB :white_check_mark: | drive/app-drive.(hash).min.css
| 40.97KB | 56KB :white_check_mark: | drive/intents-drive.(hash).min.css
| 36.91KB | 40KB :white_check_mark: | drive/onlyOffice/slide.pptx
| 24.82KB | 25KB :white_check_mark: | drive/onlyOffice/text.docx
| 5.84KB | 6KB :white_check_mark: | drive/onlyOffice/spreadsheet.xlsx
| 5.01KB | 6KB :white_check_mark: | drive/manifest.webapp
| 1.9KB | 2KB :white_check_mark: | drive/index.html
| 530B | 1KB :white_check_mark: | drive/intents/index.html
| 486B | 1KB :white_check_mark: | drive/manifest.json
| 184B | 1KB

Total files change +11B 0%

Unchanged groups (7) Status | Path | Size | Limits :------------: | ------------ | :------------: | :------------: :white_check_mark: | drive/public/**
| 1.9MB | - :white_check_mark: | drive/vendors/**
| 1.53MB | - :white_check_mark: | drive/services/**
| 516.08KB | - :white_check_mark: | drive/app/**
| 167.28KB | - :white_check_mark: | drive/intents/**
| 106.35KB | - :white_check_mark: | drive/onlyOffice/**
| 35.68KB | - :white_check_mark: | drive/img/**
| 3.41KB | -

Final result: :white_check_mark:

View report in BundleMon website ➡️


Current branch size history | Target branch size history

acezard commented 8 months ago

I suggest you add it here so that it will be available for all other add-ons in the future rather than specifically for the add menu.

Not sure, don't you mean Toolbar? https://github.com/cozy/cozy-drive/blob/fix--Add-AlertProvider-to-AddMenuProvider/src/drive/web/modules/drive/Toolbar/index.jsx

cballevre commented 8 months ago

No I mean the Bar component. The problem is that the bar does not include the same React tree as Drive. You therefore need to provide it with all the providers you use in Drive. That's why I think it's more appropriate to add into the BarRigthWithProvider component.

acezard commented 8 months ago

No I mean the Bar component. The problem is that the bar does not include the same React tree as Drive. You therefore need to provide it with all the providers you use in Drive. That's why I think it's more appropriate to add into the BarRigthWithProvider component.

updated 👍