cozy / cozy-drive

Cozy Drive Web App for Cozy Cloud
GNU Affero General Public License v3.0
171 stars 65 forks source link

[VO-942] feat: Open File in New Tab (Cmd+Click or Right-Click) #3237

Closed cballevre closed 1 month ago

cballevre commented 1 month ago
### ✨ Features

* Open File in New Tab (Cmd+Click or Right-Click)

### 🔧 Tech

* Update cozy-ui from 111.12.0 to 111.21.0

By creating this new feature, I've completely redefined the way we trigger navigation in Drive. Now we rely heavily on react-router-dom and its relative route mechanism. We're also benefiting from advances in the amiral application, which is capable of interpreting open links and redirecting them to the right applications. This allows us to make the code generic while adapting to the opening context. For example, to open a folder in the Sharing tab :

The main commit is d70ba45b218e7b0176d393ccded6143c5df81fda. The commit before are the preparation and adaptation of code after. Some noteworthy changes are :

Remaining works:

bundlemon[bot] commented 1 month ago

BundleMon

Files updated (5) Status | Path | Size | Limits :------------: | ------------ | :------------: | :------------: :white_check_mark: | vendors/drive.(hash).js
| 1.79MB (+327B +0.02%) | 2MB :white_check_mark: | public/drive.(hash).js
| 1.56MB (+68B 0%) | 1.7MB :white_check_mark: | intents/drive.(hash).js
| 87.66KB (+39B +0.04%) | 190KB :white_check_mark: | public/drive.(hash).min.css
| 39.94KB (+14B +0.03%) | 100KB :white_check_mark: | app/drive.(hash).js
| 161.12KB (-504B -0.3%) | 300KB
Unchanged files (13) Status | Path | Size | Limits :------------: | ------------ | :------------: | :------------: :white_check_mark: | public/pdf.worker.entry.(hash).worker.js
| 345.35KB | 350KB :white_check_mark: | services/qualificationMigration/drive.js
| 282.15KB | 500KB :white_check_mark: | services/dacc/drive.js
| 263.08KB | 500KB :white_check_mark: | public/cozy-client-js.js
| 159.28KB | 160KB :white_check_mark: | onlyOffice/slide.pptx
| 24.83KB | 25KB :white_check_mark: | app-drive.(hash).min.css
| 10.73KB | 56KB :white_check_mark: | intents-drive.(hash).min.css
| 7.89KB | 40KB :white_check_mark: | onlyOffice/text.docx
| 5.85KB | 6KB :white_check_mark: | onlyOffice/spreadsheet.xlsx
| 5.02KB | 6KB :white_check_mark: | manifest.webapp
| 1.87KB | 2KB :white_check_mark: | index.html
| 597B | 1KB :white_check_mark: | intents/index.html
| 507B | 1KB :white_check_mark: | manifest.json
| 185B | 1KB

Total files change -57B 0%

Groups updated (4) Status | Path | Size | Limits :------------: | ------------ | :------------: | :------------: :white_check_mark: | vendors/**
| 1.79MB (+327B +0.02%) | - :white_check_mark: | public/**
| 2.11MB (+81B 0%) | - :white_check_mark: | intents/**
| 88.15KB (+39B +0.04%) | - :white_check_mark: | app/**
| 161.12KB (-504B -0.3%) | -
Unchanged groups (3) Status | Path | Size | Limits :------------: | ------------ | :------------: | :------------: :white_check_mark: | services/**
| 545.23KB | - :white_check_mark: | onlyOffice/**
| 35.7KB | - :white_check_mark: | img/**
| 5.85KB | -

Final result: :white_check_mark:

View report in BundleMon website ➡️


Current branch size history | Target branch size history

paultranvan commented 1 month ago

Behold the mighty long-expected feature! :heart:

cballevre commented 1 month ago

@zatteo I did a quick test of the notes on the flagship app. It opens the Notes app in a new webview and when you come back it returns to Drive. So nice that flagship app interprets opened link so we can remove custom code inside others applications