Closed cballevre closed 1 month ago
Total files change -57B 0%
Final result: :white_check_mark:
View report in BundleMon website ➡️
Behold the mighty long-expected feature! :heart:
@zatteo I did a quick test of the notes on the flagship app. It opens the Notes app in a new webview and when you come back it returns to Drive. So nice that flagship app interprets opened link so we can remove custom code inside others applications
By creating this new feature, I've completely redefined the way we trigger navigation in Drive. Now we rely heavily on
react-router-dom
and its relative route mechanism. We're also benefiting from advances in the amiral application, which is capable of interpreting open links and redirecting them to the right applications. This allows us to make the code generic while adapting to the opening context. For example, to open a folder in the Sharing tab :sharing
../${file.id}
so react-router-dom can replace the current folder with the new id This limit the props drilling and reduce code.The main commit is d70ba45b218e7b0176d393ccded6143c5df81fda. The commit before are the preparation and adaptation of code after. Some noteworthy changes are :
useFileLink
is used to open favorite inside the navigation sidebarRemaining works:
Test all navigation casesMake unit tests onuseFileLink
to avoid repetitive testingAdd more extensive message to some commit