cozy / cozy-emails

Email Client for Cozy
GNU Affero General Public License v3.0
66 stars 41 forks source link

Problematic github case for conversation #815

Open aenario opened 8 years ago

aenario commented 8 years ago

The current algorithm to group conversations rely on trying to find a new message ancestor through its message-id.

When I create a PR on github or if my notifications are not setup, i dont receive the original message of this discussion. And all following messages will have as only reference the first message in the thread, so they wont be merged into a conversation.

We should instead search by reference an group all messages having a reference in common. This is what the conversation-patching part of the code was suppose to accomplish, but it apparently dont. This need to be investigated more deeply.


Side note :

My intuition is that this issue is caused by the layers of retrocompatiblity. It would be beneficial for email server-side to declare a bankroute and simplify and remove all the code we have for retrocompatiblity. From the top of my head :

However, this would imply to say "v2 is not compatible with v1, you will need to reimport all your emails" or to have a last patch to rules them all (harder).