cozy / cozy-emails

Email Client for Cozy
GNU Affero General Public License v3.0
66 stars 41 forks source link

Move Router dispatch to uniq ROUTE_CHANGE #823

Closed m4dz closed 8 years ago

m4dz commented 8 years ago

This PR clean routing and actionsCreators.

misstick commented 8 years ago

@m4dz : I also made "few" changes that should conflict here.

  1. which one should be merged first?
  2. however, we must be careful when rebasing our branches (regressions)

See : https://github.com/cozy/cozy-emails/pull/819 and https://github.com/cozy/cozy-emails/pull/814

frankrousseau commented 8 years ago

Too much PR open for the end of the sprint. Please merge or close them on monday.

m4dz commented 8 years ago

@misstick rebase ok for me, but there's some tests needed when merging with #819/#814. Can we do this on monday morning in peer-review?

misstick commented 8 years ago

@m4dz : don't forget to remove dead code; otherwise pretty good cleanup of utils 👍

misstick commented 8 years ago

@m4dz : don't worry about #819/#814 : I will merge this one and rebase mine after