cozy / cozy-emails

Email Client for Cozy
GNU Affero General Public License v3.0
66 stars 41 forks source link

[FIX] merge conflicts between #823 and #814 #826

Closed misstick closed 8 years ago

misstick commented 8 years ago

- [ ] FIX error_manager.coffee:29 POST http://localhost:9125/activity 413 (Payload Too Large), - [ ] Keyboard navigation is broken

misstick commented 8 years ago

@m4dz : is error_manager.coffee:29 POST http://localhost:9125/activity 413 (Payload Too Large) normal? why?

misstick commented 8 years ago

@m4dz can you explain why Keyboard navigation is broken? and why I shouldnt FIX it?

m4dz commented 8 years ago

About unfixed bugs:

  1. "Payload too large" is an error that occurs when React try to POST console.debug logs to the server logger. It never occurs in production mode, as the React console.debug calls are triggered when app run in __DEV__ config, so we can safely ignore them
  2. Keyboard navigation is broken because it is handled via a plugin, and we decided to trash the actuel plugins stack, and 1/ reintroduce it maybe later if needed (with a dedicated API); 2/ add keyboard events supports natively in the app. So feel free to let it unfixed at this time :smiley:
m4dz commented 8 years ago

@misstick can i let you rebase it on development? Thanks!