Closed m4dz closed 8 years ago
Dont forget to hide custom configuration fields!
Ready-to-review! Still lacks:
But I think we can do them in another PRs :smile:.
Thanks!
In my mind, we'll be able to merge this PR when redirection to 'account/new' will work. Indeed, creation of a second account isn't possible for the moment.
Better layout design, dead code cleaning and tests can be merge in another PR.
@m4dz : shouldnt you remove old components? Is this available to edit accounts?
Nice work! You should remove old code that seems to conflict with the new one; keep in mind that mixins
are anti-pattern
and all data logic should be moved as much as possible into getters. 👍 Keep focus, and everything should be OK. I'm gonna write these things into documentation (such as mixins
are anti-pattern)
@m4dz : I will merge this PR into developement
but we will have to finish this review tomorrow
@m4dz : shouldnt you remove old components? Is this available to edit accounts?
Yep: it's in my scope for the current sprint. If we have some extra-time, we'll probably can create the edit component that reuse the <Servers>
one.
This PR introduces a new component to manage Account creation and Settings:
Unit test view on custom behaviors (such as magic inputs reflection)Test consistent component stateClean old account creator