Move Utils into Getters

cozy / cozy-emails

Email Client for Cozy

GNU Affero General Public License v3.0

66 stars 41 forks source link

Move Utils into Getters #842

Closed misstick closed 8 years ago

misstick commented 8 years ago

[x] remove dead code,
[x] remove useless mixin (ie. un-used or called once),
[x] remove useless utils (ie. un-used or called once),
[x] remove stores calls into components,
[x] move utils into libs

m4dz commented 8 years ago

Ok for me. @misstick can you rebase on development? Thanks!

misstick commented 8 years ago

@m4dz : dont forget to look PR labels : this PR is not finished yep :)

m4dz commented 8 years ago

dont forget to look PR labels

oops, you've assigned me, I've presumed that the PR was ready. Thanks to remind me ;)

frankrousseau commented 8 years ago

I propose you to merge this one directly. It's too hard to review it properly (too many changes).

m4dz commented 8 years ago

@misstick why have you move performance mesurement and reporting initilializers to NotificationActionCreator?

misstick commented 8 years ago

@m4dz : because the test made about perf produce notifications as well as reporting; not a good idea?

misstick commented 8 years ago

@frankrousseau: this PR is about moving a lot of files so it is about architecture cleansing; even if there are a lot of changes, I'd like to know if the moves are OK

m4dz commented 8 years ago

Hmm, I don't think so: reporting, realtime, performance… are parts of the whole app, used everywhere, and I think they must belongs on their own parts (libs?) and not lost in another component.