Creation wizard lib tests

cozy / cozy-emails

Email Client for Cozy

GNU Affero General Public License v3.0

66 stars 41 forks source link

Creation wizard lib tests #866

Closed m4dz closed 8 years ago

m4dz commented 8 years ago

Tests for the Account creation wizard lib:

[x] validateState
[x] sanitizeConfig
[x] parseProviders

misstick commented 8 years ago

@m4dz : I don't see the point of prefixing commit with [test] because its the goal of this PR; I think that you can a flag to the PR, such as test. This is done form enhancement or bug, why not for tests?

Look at my previous comment to add more lisibility to your test; otherwhise everything looks good to me! 👍

m4dz commented 8 years ago

I don't see the point of prefixing commit with [test]

Because of https://github.com/commitizen/cz-cli#using-the-command-line-tool :smiley:. We don't use explicitely Commitizen, but I use their prefix convention for commits.

Okayyy... I also added a label to this PR.