[fix] Gmail mailboxes issues

cozy / cozy-emails

Email Client for Cozy

GNU Affero General Public License v3.0

66 stars 41 forks source link

[fix] Gmail mailboxes issues #868

Closed misstick closed 8 years ago

misstick commented 8 years ago

[x] Inbox belongs to flaggedMailbox; it should appear on top of mailboxes list,
[x] Inbox isnt found for gmail accounts,
[x] spinner is always visible into [Gmail] mailbox,
[x] special mailbox icons are not found (drafts, deletedMessages, etc.).

misstick commented 8 years ago

@aenario: I found that gmailInbox is not flagged as it should; mailbox.tree is not the same as OVH, ie. We have to look at mailbox.attribs instead. Did you know it? I'd love you tell me that long story :)

misstick commented 8 years ago

@m4dz : can you review this PR; its quite old and finished :(

frankrousseau commented 8 years ago

ping @aenario Can you help on some emails review? (if @m4dz is not available of course)

m4dz commented 8 years ago

I'm on it (sorry for the delay :/)

aenario commented 8 years ago

@misstick If i recall correctly, the idea is that we should trust mailbox.attribs when possible.

However,

some providers dont have attribs to their mailboxes at all, so we attempt to guess by the name.
in some cases (like every cozy team member who switched from gmail to OVH), the hierarchy is weird (INBOX > INBOX / INBOX > Sent), see tests fixtures. This was an attempt to have the displayed tree cleaner in these cases.

m4dz commented 8 years ago

Thanks :tada: ! (and again, sorry for the delay)