search

cozy / cozy-emails

Email Client for Cozy
GNU Affero General Public License v3.0
66 stars 41 forks source link

Ensure that client tests run properly #880

Closed frankrousseau closed 8 years ago

frankrousseau commented 8 years ago

This PR brings some cleaning in the code and in tests files to ensure that every client side tests run properly.

Once this PR will be merged, the command npm run test:client will work on Travis.

Sorry for the messy history, but I don't know how to make things proper without spending hours on it.

misstick commented 8 years ago

@frankrousseau: I'm confused about all this diff. Your PR add some stuff ever added by @m4dz in PR merged yesterday. Merging this PR right now could set the history up side down.

I prefer ask @m4dz to see what he can do about this.

Please, create a new branch from development next time; you will only have to rebase it from dev to bue up to date.

misstick commented 8 years ago

A note about the aim of this PR and the fact that we work together at the same time on the same stuff: please don't hesitate to create your PR when you are working on and not when it is finished then everybody could see that someone is working on that subjet.

frankrousseau commented 8 years ago
  1. It's normal that the PR adds stuff from @m4dz because I merged his development.
  2. This PR won't affect much your work, it's just fixing what was required to be fixed. No worries.

I merged it because it's the end of the sprint and because I would like to see tests running on the client side for this repository.

misstick commented 8 years ago

@frankrousseau: having green test is not the only reason to merge tests; there was a lot of others that you didn't wanted to care about (see comments above); what is review for then?

frankrousseau commented 8 years ago

From a delivery point of view, it matters a lot. You will be happy soon to rely on the continuous integration when you ship new code. Sorry for merging it fast but it's important for the project and it's the end of the sprint.