[lint] Add server code linting to Continuous Integration

cozy / cozy-emails

Email Client for Cozy

GNU Affero General Public License v3.0

66 stars 41 forks source link

[lint] Add server code linting to Continuous Integration #883

Closed frankrousseau closed 8 years ago

frankrousseau commented 8 years ago

I fixed linting (I only removed errors, warning are still present) and made linting available on Travis continuous integration.

frankrousseau commented 8 years ago

Please do not review / merge yet, some code is not linted.

frankrousseau commented 8 years ago

OK, this PR is mergeable.

frankrousseau commented 8 years ago

Oups, no... travis is red...

Edit: Travis build is fixed.

m4dz commented 8 years ago

@frankrousseau nice :+1: !

What about scripts namespaces ? Isn't better to limit to 3 levels (lint:server:coffee) or are the specificity really relevant? /poke @aenario if you've got any thoughts?

frankrousseau commented 8 years ago

The problem is that coffeelint and coffeejshint are very different. I think it's time to move forward: overall benefits of this PR overcome this namespace discussion. If you want to change the namespaces, you can propose another PR and we will have the discussion there.

m4dz commented 8 years ago

Thanks @frankrousseau :tada: