Prevent application to crash when there is no account

cozy / cozy-emails

Email Client for Cozy

GNU Affero General Public License v3.0

66 stars 41 forks source link

Closed gregorylegarec closed 7 years ago

gregorylegarec commented 7 years ago

On my first launch, Emails crashed with an error related to undefined account. This PR fixes this issue.

I still have unit tests to write (I am currently looking at existing tests)

@misstick please review, or assign someone else. :)

misstick commented 7 years ago

Hi @gregorylegarec can you answer this question to add context for this PR plz?

what is it for? (you can fil description with the purpose or issue this PR is about),
Have you finished (ie. labels, checklist into description field)?
Are you waiting for review?
from who (cf assignees)?
will you add some test (if possible with actual environment),
etc.

... and welcome on Email beautiful project :]

misstick commented 7 years ago

This test doesnt actually exist but will in PR above; don't lose time looking at a test that doesnt exist :)

Can I merge this?

misstick commented 7 years ago

@gregorylegarec: I think this PR is useless because of https://github.com/cozy/cozy-emails/pull/898 Sorrryyyyyy :(

I can check I may be wrong

gregorylegarec commented 7 years ago

Yep it seems that you're right.

No problem for me.