search

cozy / cozy-emails

Email Client for Cozy
GNU Affero General Public License v3.0
66 stars 41 forks source link

[DO NOT MERGE] Redux #902

Closed aenario closed 8 years ago

m4dz commented 8 years ago

Woohoooo \o/ ! Nice shot!

Firstly, this is just an awesome POC, and I'm really (really really) happy to see it happen. And your proposal for this migration is really pretty, hope it mean the rest will be so easy too.

Here my though about:

  1. I see you always rely on Getters, even in ActionCreators or in others Getters. Do we consider that the only good way to retrieve content form Redux Store is to use Getters everywhere (I'm totally fine with that, just a matter to confirm it)
  2. I just :heart: so much using props everywhere in all components including Application and the redux-connect-like solution, seems perfect to me!
  3. I see that you've isolated some curation logics in utils. We've previously try to avoid utils in favor of libs, just to try to not put too many things everywhere. We just need to sync our watches by documenting which part of code does what and where. (misstick) +1
gregorylegarec commented 8 years ago

I began to write down a few remarks/questions: they are not fix requests but true questions, they have to be taken like so. :)