Closed Ldoppea closed 9 months ago
I fixed a bug I introduced in the CozyApp fallback detection here: https://github.com/cozy/cozy-flagship-app/compare/c69d4ec154983da33c475119762b5dab1ae09da0..bf946dd7533e9403ed88f4697525eeb00f192b80
Also I fixed unit tests here: https://github.com/cozy/cozy-flagship-app/pull/1092/commits/d89c4911ed7dbf38867b4e03c9d2fe41dfa4124e
The Lock related screens are responsible to lock the app when it goes to OS background and to display a CTA to the user when their phone is not protected
Previous implementation declared those screens inside of the App's router
This had numerous caveats:
navigate()
in reaction of an event while behind the lock screen then the app would leave the lock screenCanceled by another authentication
This PR removes those screen outside of the router
With the new implementation, those screen are now displayed on top of the UI without interaction with the router
This allow the application to live behind the Lockscreen, so:
navigate()
collision anymore, the app can do navigation in background based on events and this won't affect the fact that the Lock screen is always displayed until the user enters their credentials<App />
component, so there should be no risk of rerender side effects between each-otherTODO:
hasRenderedOnce
ref,useEffect
name and logs)