cozy / cozy-flagship-app

GNU Affero General Public License v3.0
9 stars 1 forks source link

[VIO-129] feat: Extract Lock related screens from router #1092

Closed Ldoppea closed 9 months ago

Ldoppea commented 10 months ago

The Lock related screens are responsible to lock the app when it goes to OS background and to display a CTA to the user when their phone is not protected

Previous implementation declared those screens inside of the App's router

This had numerous caveats:

This PR removes those screen outside of the router

With the new implementation, those screen are now displayed on top of the UI without interaction with the router

This allow the application to live behind the Lockscreen, so:


TODO:

Ldoppea commented 9 months ago

I fixed a bug I introduced in the CozyApp fallback detection here: https://github.com/cozy/cozy-flagship-app/compare/c69d4ec154983da33c475119762b5dab1ae09da0..bf946dd7533e9403ed88f4697525eeb00f192b80

Also I fixed unit tests here: https://github.com/cozy/cozy-flagship-app/pull/1092/commits/d89c4911ed7dbf38867b4e03c9d2fe41dfa4124e