Closed acezard closed 8 months ago
I have too comments about this.
First, why did you create the repository in the
cozy-labs
org instead of instead of thecozy
one? There are already a few react-native forks in thecozy
one (cf here)Also, I would suggest to use only PRs in those repositories, this would help to list all Cozy's edits from a single search (the PR page) in the future. However this is nit as I don't expect the original repo to suddenly get new commits in the future, so we won't need to do a merge upstream. But keep in mind that for other repos using PRs would ease a lot.
Also I added 2 comments to the new repo's commits, I don't know how to keep track of them as they are not in a PR so I put them here:
you're right it should be in cozy namespace, and use PR rather than commit to main directly. Also keep history of the first change and check why it was made exactly
@Ldoppea updated there https://github.com/cozy/react-native-gzip/releases/tag/1.0.0
🐛 Bug Fixes