search

cozy / cozy-home-v2

This repository was part of CozyV2 which has been deprecated
https://blog.cozycloud.cc/post/2016/11/21/On-the-road-to-Cozy-version-3
GNU Affero General Public License v3.0
94 stars 53 forks source link

Change application branch during update #562

Open poupotte opened 9 years ago

poupotte commented 9 years ago

If branch declared in cozy-registry has changed, home should change branch during update. See https://github.com/cozy/cozy-controller/issues/57

frankrousseau commented 9 years ago

I'm not sure about that one. It's a good simplification to force every app to have a master branch.

bnjbvr commented 9 years ago

It does seem appropriate. The stable branch / development branch of a given repository should be an implementation detail, transparent to the end-user. As a Cozy app developer, I'd like to change my development branch to master and have a stable branch (or maybe even use tags). Users shouldn't need to have to uninstall/reinstall the app just because of this hosting detail.

frankrousseau commented 9 years ago

It looks like I changed my mind since may :). Thank you @poupotte for the link.

@bnjbvr I understand the benefit. But having a standard in naming the master branch make things simpler for new developers. It doesn't harm the current developers to stick with the master branch.

bnjbvr commented 9 years ago

@frankrousseau I am not sure we are talking about the same thing here, and it's ok :-) So when I was talking about the "end user", I had in mind "the user of the app". Currently for Kresus, the development branch is incoming and the stable branch is master. I would like the development branch to be master and the stable branch to be stable, instead (so that I can benefit from greenkeeper.io, for instance). As of today, for this to happen, 1) I would need to change the branch in the cozy-registry and 2) all Kresus' users would need to uninstall and reinstall the app (unless they're willing to have bugs sometimes). Having to do 2) is suboptimal and shouldn't require any user interaction -- it seems that it is something the controller could easily do.