search

cozy / cozy-home-v2

This repository was part of CozyV2 which has been deprecated
https://blog.cozycloud.cc/post/2016/11/21/On-the-road-to-Cozy-version-3
GNU Affero General Public License v3.0
94 stars 53 forks source link

Icon in "shop" #799

Open Zykino opened 8 years ago

Zykino commented 8 years ago

I saw this issue in download app : Icon missing #10 It says that the cozy team need to add manually the icon displayed in the shop.

Why don't you use the one provided by the developer? It should be synced with the one displayed once installed so you can use the one in this folder (in this example) : /client/app/assets/icons

I suppose the icon is normalized for the cosy apps so why not using it everywhere?

clochix commented 8 years ago

We use the icon provided by the developer when installing application from their Github repository, and icons from the Home when installing from the marketplace.

Maybe @m4dz remembers the rational behind this behavior.

m4dz commented 8 years ago

It's a somewhat so complicated tech use case, so, I'll try to explain it simply: I have litterally no idea why we're doing this :laughing:. Obviously, we should use the icon provided by the app in its assets, as declared in the package.json manifest.

I suppose there was a time, long time ago (when dragons controlled everythings on earth), when we faced any issues that force us to embed icons for the Marketplace (the first reason I can see is that we can't get the icon if the app isn't present in the FS). But this is definitely not a good way to deal with it, and we'll find another better solution when we work on the new home /apps / stack :smile:.

nono commented 8 years ago

Cf https://github.com/cozy/cozy-registry/issues/19