search

cozy / cozy-ical

ICal Parser and Calendar models for Cozy Cloud
http://cozy.io
Other
29 stars 11 forks source link

Preserve timestamp of input #60

Open RubenVerborgh opened 4 years ago

RubenVerborgh commented 4 years ago

As described in https://github.com/cozy/cozy-ical/issues/59, the serializer-interpreted any date given to it using the machine's current timezone. This would lead to the same code having different results on the different machines, and to cozy-ical writing down a file differently after reading it.

This PR modifies the behavior of vEvent to respect the timestamp of a Date, thereby matching ICalParser's behavior.

This PR first adds a failing integration test for the case in https://github.com/cozy/cozy-ical/issues/59, and then fixes this case, changing existing unit tests along its way.

Depending on whether the old behavior was considered intentional or not, this PR might introduce a breaking API change, and hence need to be released as a new major version.

Fixes https://github.com/cozy/cozy-ical/issues/59

RubenVerborgh commented 4 years ago

Tagging recent committters @nono @digitalica in the hope they're able to help.

digitalica commented 4 years ago

Tagging recent committters @nono @digitalica in the hope they're able to help.

i have no write accesss here, so not sure how i can help

nono commented 4 years ago

The project is no longer maintained. Maybe you can fork it.