search

cozy / cozy-photos-v2

Deprecated - New : https://github.com/cozy/cozy-drive/tree/master/src/photos - Personal Photo Gallery Manager
http://cozy.io
GNU Affero General Public License v3.0
27 stars 25 forks source link

Manage instantly counter plural #117

Closed clochix closed 8 years ago

clochix commented 9 years ago

See https://forum.cozy.io/t/cozy-photos-does-not-manage-items-singular-plural-instantly/425 When uploading photos to an album, we should update the counter singular / plural. Thanks @goofy-bz for noticing.

0gust1 commented 8 years ago

Pluralization does not work at the moment.

Polyglot wants a smart_count parameter with a length attribute to manage pluralization, and actually it's an number which is passed. This behavior is fixed in the current version of polyglot (https://github.com/airbnb/polyglot.js/blob/master/lib/polyglot.js#L200)

I don't know what to do here. The proper way would be to use the last version of polyglot, but actually the dependency is not managed with npm :-/

clochix commented 8 years ago

Thanks for your fix @0gust1, it works fine now, @goofy-bz will be happy ☺

ghost commented 8 years ago

Confirmed. clipgoofyhat /me hats off for 0gust1

0gust1 commented 8 years ago

Thanks, it was not a tremendous contribution, but I was glad to help a little :)