cozy / cozy-photos-v2

Deprecated - New : https://github.com/cozy/cozy-drive/tree/master/src/photos - Personal Photo Gallery Manager
http://cozy.io
GNU Affero General Public License v3.0
27 stars 25 forks source link

Handle videos #28

Open dolanor opened 10 years ago

dolanor commented 10 years ago

Hello,

I was looking at camlistore for a while, but their UI is generic (and filled with geeky stats at the moment), and therefore, for photo album it isn't great. But yours is awesome, and the upload of pictures is a breeze. I wanted some easy to use system for friends to post pictures after an event. But a lot of time, pictures comes with videos. I think having an interface to display video would be great, and a way to upload video too.

Is the 10MB limit for picture upload could be increased for video ? Would it create some performances problems, or is it more for storage space on the server side ?

aenario commented 10 years ago

Hi dolanor, thanks for the idea !

Supporting videos is on the roadmap, however we need to improve our file handling first : as for now, we do not stream uploads in apps or datasystem so the pictures are written 3 times on disk (once in cozy-photos, once in cozy-datasystem, once in couchdb). This make the upload way slower than it should be and we need to fix this before supporting large file upload such as videos.

Moreover, there is some thinking/research to do about which video format can be displayed as

Storage space is not an issue as it is enforced at the VM level (to allow hardware limited storage for selfhosters)

I'll keep this issue open and ping it when we start working on it.

dolanor commented 10 years ago

As I kind of need the support for video quickly and I don't really care about performances and space lost, could you help me making a quick fix with that ? Here is my quick and dirty fix : https://github.com/dolanor/cozy-photos-vid/commit/4acb7a8e6a3bff02ad6f588d50a4054dd3fe8639

But when I install my application, the app.js is still checking against 10 * 1024 * 1024. What should I do to update it ?

By the way, what is the level of compression of the zip archive for pictures ? Since images and video are already compressed, I suppose it is a 0 level compression to not lose time/CPU ?

aenario commented 10 years ago

you will need to compile your client side :

     npm install -g brunch
     cd client
     npm install
     brunch b

Regarding compression, I must admit i just copy-pasted zipstream example , which use zlib with level=1 (MAX SPEED), a level=0 (NO COMPRESSION) would be more appropriate.

dolanor commented 10 years ago

Ok, thank you, it was what was missing ! I could regenerate my js, but my very quick and very dirty didn't work out, too many things need to be changed even when not talking about the triple copy of data. I will be using proprietary cloud for this special need, but I'll be happy to hear from you when you will update for videos :) Thank you !

dkm commented 9 years ago

Ping ? Is it still planned ? Any idea when we can expect even a basic support ? If not, then I have to find a substitute

clochix commented 8 years ago

Another user is asking for this feature: he imported its multimedia files from Google, this also imported videos, but he is unable to display them.

clochix commented 8 years ago

Handling videos imported from Google may not be easy. Here's what we have in database:

{
  "_id": "140b39749a75bd36dd27fce81a461360",
  "_rev": "5-6f5e503108e12a9ac5dba35f986e68c7",
  "title": "20130525_182921.mp4",
  "albumid": "140b39749a75bd36dd27fce81a4605c4",
  "docType": "photo",
  "binary": {
    "raw": {
      "id": "140b39749a75bd36dd27fce81a461a22",
      "rev": "2-984cdafff936db57ce9d74570d386bff"
    },
    "thumb": {
      "id": "140b39749a75bd36dd27fce81a461a33",
      "rev": "2-f97635da0cdbf0dba860bf9988a5edcf"
    },
    "screen": {
      "id": "140b39749a75bd36dd27fce81a462152",
      "rev": "2-6de957288fe5e39934d885a607b5f02e"
    }
  },
  "gps": {}
}

The only way to know it is a video is to look at the file extension inside the title :-S

We should probably first do something on the import application, to mark this documents as photos.

clochix commented 7 years ago

One more user is requesting this feature (by email).