search

cozy / cozy-photos-v3

Cozy Photos app for Cozy Cloud
GNU Affero General Public License v3.0
1 stars 9 forks source link

feat: Add 'who has access' to sharing modal #142

Closed GoOz closed 7 years ago

GoOz commented 7 years ago

Add the view that displays the access list

@TODO get the access list from the API.

GoOz commented 7 years ago

(2) [PHO] Onglet "Who has access" dans la modale de partage en lecture seule

y-lohse commented 7 years ago

So far so good! But I guess we'll amend this PR with the logic bits?

GoOz commented 7 years ago

This is not for merging purpose right now, just to be reviewed in advance 😛 In case i didn't take the right path from the beginning.

enguerran commented 7 years ago

I added some functions, but faced an error on GET /sharings/:id with :id a sharing's id found in the permissions sets that is returned by GET /permissions/doctype/io.cozy.files/sharedWithOthers... I asked @Ljinod for a tips, and we will added the information in the FAQ: Great! I know that my resource is shared. Can I have more information regarding the sharing?.

enguerran commented 7 years ago

@GoOz @y-lohse, @goldoraf I think I'm done with this. Could you review my changes?

Note: all logic must go into redux-cozy-api, but for now, I write it right in the sharing/index.js lib file. As you can see if you run the code, there is a wrong behavior in the sharing modal as if you switch tab before fetching all needed data, it will go back to the first tab. That is not related to this feature, so I let it as this. But we should consider to refactor it later.