search

cozy / cozy-photos-v3

Cozy Photos app for Cozy Cloud
GNU Affero General Public License v3.0
1 stars 9 forks source link

refactor: Optimizing the PhotoList component to have a single Dimensi… #42

Closed kosssi closed 7 years ago

kosssi commented 7 years ago

There is a problem with the Dimension component that adds a div with the following style for each PhotoList (I think it's not necessary):

overflow: visible; height: 0px; width: 0px;

So I prefer create an PhotoLists component with only one Dimension.

gregorylegarec commented 7 years ago

It looks ok, but shouldn't this component be in a dedicated file instead of exporting two component in PhotoLists ?

EDIT: Also, it was already the role of PhotoBoard to wrap all photoLists, did you attempt to apply the Dimensions component to it ?

gregorylegarec commented 7 years ago

Looks great to me 👍