Refactoring - Githubissues

cozy / cozy-photos-v3

Cozy Photos app for Cozy Cloud

GNU Affero General Public License v3.0

1 stars 9 forks source link

Refactoring #45

Closed enguerran closed 7 years ago

enguerran commented 7 years ago

Changes:

e199708 (Enguerran, 9 minutes ago) refactor: album to ducks :dragon:
2073905 (Enguerran, 2 hours ago) fix: default route when no match :twisted_rightwards_arrows:
e397a62 (Enguerran, 26 hours ago) refactor: s/App/Layout/ :tulip:
2a12f07 (Enguerran, 33 hours ago) refactor: put variables in scope :cherry_blossom:

enguerran commented 7 years ago

Regarding the commit 3404bf9 you need to accept that this refactoring has been done for the code only, not for the tests. That is why you'll see some weird string instead of previous actionType in mango.js and ui.js. Please note that those tests look like smell code as they import actionType, while, in ducks architecture, there is no need to export actionType.