search

cozy / cozy-photos-v3

Cozy Photos app for Cozy Cloud
GNU Affero General Public License v3.0
1 stars 9 forks source link

feat: Add Share button + share modal #74

Closed enguerran closed 7 years ago

enguerran commented 7 years ago

The first step for sharing an album:

  1. open an album
  2. click on the share button
  3. in the modal, toggle the share by link button
  4. copy/paste the link with 2 query parameters sharecode and id

Note that for now the link does not do anything.

I need to update cozy-client-js as this PR needs https://github.com/cozy/cozy-client-js/pull/160

enguerran commented 7 years ago

Everything is ok for me. Please review the code and give me an approval.

enguerran commented 7 years ago

(2) [PHO-28 Partage d'un album par lien] Générer un lien de partage

enguerran commented 7 years ago

I push -fed because of a typo in a commit's message. (s/restaure/restore/)

enguerran commented 7 years ago

@goldoraf As I do not have a confirm action, I guess there is no problem not to have a promise as saga (cf. https://github.com/cozy/cozy-photos-v3/blob/master/src/lib/confirm.js)