Closed enguerran closed 7 years ago
Crap, I miss something from the cozy-client-js
API https://github.com/cozy/cozy-client-js/pull/164
Before merging into master
I add to update cozy-client-js
version.
Is the style adjustments scheduled afterwards, in another cards?
@GoOz I guess it does not because we believed we could reuse already developed components. But regarding the state of the art in this very project, we cannot reuse components.
If we have some effort to put in this, I think we should put it into the component's refactoring to reuse already developed styled components instead of wasting time in redeveloping style for this tiny component.
What are the problems you spotted on?
Well, according to the screenshots, almost everything is wrong. I didn't test it, i just saw those screenshots. Wrong font, wrong, border, wrong margins, etc…
@GoOz What if we merge this PR in terms of "a small step is better than nothing". Then, if needed, we will put some CSS to beautify those screens?
It handles shared album by link with links like
http://photos.cozy.tools:8080/public?sharecode=eyJhbGciOiJIUzUxMiIsInR5cCI6IkpXVCJ9.eyJhdWQiOiJzaGFyZSIsImlhdCI6MTQ5NTExOTIzOCwiaXNzIjoiY296eS50b29sczo4MDgwIiwic3ViIjoiZW1haWwifQ.Fo181yCEQoktjCVGr0pTdsU-W-GB_AizI1tGZm-X-lK6GYz2Bqts6yYwoEHDkVYJJgeFVy2UTqYkliYkb4pc6w&id=f6f96990b5af9be2b04ca9f832000c5f
wheresharecode
andid
are respectively a cozy token with specific permissions and the shared album id.