cozy / cozy-photos-v3

Cozy Photos app for Cozy Cloud
GNU Affero General Public License v3.0
1 stars 9 forks source link

feat: a very beautiful public page #77

Closed enguerran closed 7 years ago

enguerran commented 7 years ago

It handles shared album by link with links like http://photos.cozy.tools:8080/public?sharecode=eyJhbGciOiJIUzUxMiIsInR5cCI6IkpXVCJ9.eyJhdWQiOiJzaGFyZSIsImlhdCI6MTQ5NTExOTIzOCwiaXNzIjoiY296eS50b29sczo4MDgwIiwic3ViIjoiZW1haWwifQ.Fo181yCEQoktjCVGr0pTdsU-W-GB_AizI1tGZm-X-lK6GYz2Bqts6yYwoEHDkVYJJgeFVy2UTqYkliYkb4pc6w&id=f6f96990b5af9be2b04ca9f832000c5f where sharecode and id are respectively a cozy token with specific permissions and the shared album id.

enguerran commented 7 years ago

screenshot at 17-28-31 screenshot at 18-08-32

enguerran commented 7 years ago

Crap, I miss something from the cozy-client-js API https://github.com/cozy/cozy-client-js/pull/164

enguerran commented 7 years ago

Before merging into master I add to update cozy-client-js version.

enguerran commented 7 years ago

(2) [PHO-29 Partage d'un album par lien] Liste des photos de l'album partagé dans la page publique

GoOz commented 7 years ago

Is the style adjustments scheduled afterwards, in another cards?

enguerran commented 7 years ago

@GoOz I guess it does not because we believed we could reuse already developed components. But regarding the state of the art in this very project, we cannot reuse components.

If we have some effort to put in this, I think we should put it into the component's refactoring to reuse already developed styled components instead of wasting time in redeveloping style for this tiny component.

What are the problems you spotted on?

GoOz commented 7 years ago

Well, according to the screenshots, almost everything is wrong. I didn't test it, i just saw those screenshots. Wrong font, wrong, border, wrong margins, etc…

enguerran commented 7 years ago

@GoOz What if we merge this PR in terms of "a small step is better than nothing". Then, if needed, we will put some CSS to beautify those screens?