search

cozy / cozy-proxy

This repository was part of CozyV2 which has been deprecated - Cozy authentication and routing layer
https://blog.cozycloud.cc/post/2016/11/21/On-the-road-to-Cozy-version-3
GNU Affero General Public License v3.0
26 stars 31 forks source link

Refresh proxy locale when updating #282

Closed m4dz closed 8 years ago

m4dz commented 8 years ago

This PR fix a locale loading bug that occurs when update locale settings in home: the new setting wasn't applied since the proxy is restarted. This PR fix it by forcing locale refresh into the proxy when accessing a frontend page (register / index / password-reset).

nono commented 8 years ago

@m4dz the build is red, with many Cannot find module '../locales/en_US.UTF-8' errors

m4dz commented 8 years ago

Hmmm, seems to be a glitch in request-json when it transmits accepted locales. I investigate…

frankrousseau commented 8 years ago

@m4dz What is the status of this PR?

m4dz commented 8 years ago

Unfortunately, test always fail on Travis, and liiterally crash locally (and I couldn't find enough time to fix it). I'll try as soon as possible to close this one, I just need to fix this damned headless test and everything'll bo ok :smiley:.

frankrousseau commented 8 years ago

ping @m4dz

m4dz commented 8 years ago

I'm on it

nono commented 8 years ago

@m4dz any news?

m4dz commented 8 years ago

Always the same shit with local tests :disappointed:. I'll try to fix it next monday!

frankrousseau commented 8 years ago

This PR is opened from may 27. I think it's time to close it. The addition is interesting but it looks like noone has time to take care of it. What do you thing @m4dz?

m4dz commented 8 years ago

@frankrousseau I should agree with you: I can't find any sufficient time to properly fix tests env. Let's close it, and I'll re-open later when I can finally fix this issue :disappointed:.