cozy / cozy-proxy

This repository was part of CozyV2 which has been deprecated - Cozy authentication and routing layer
https://blog.cozycloud.cc/post/2016/11/21/On-the-road-to-Cozy-version-3
GNU Affero General Public License v3.0
26 stars 31 forks source link

Add active steps detection #307

Closed gregorylegarec closed 7 years ago

gregorylegarec commented 7 years ago

Thanks @m4dz to have a review. (ping also @CPatchane and @misstick)

This PR add a way to detect if an onboarding step is active, i.e. it it has to appear in the onboarding flow.

To handle that, it adds an isActive(user) method to Onboarding Step class, which specifies if the step has to be active for a given user (See documentation).

This method may be overriden by config steps. See for example infos step.

Infos step

Also, it add the infos step, only active when given user don't have valid email or timezone.

Also added

nono commented 7 years ago

@gregorylegarec coffeelint is not happy :wink:

gregorylegarec commented 7 years ago

@nono Oops, sorry. It's the second time that it happens to me, I will see how I could add coffeelint to the npm watch task. :)

gregorylegarec commented 7 years ago

@nono Should be fixed now.

nono commented 7 years ago

@gregorylegarec you can also remove node 0.10 and node 0.12 in travis.yml

m4dz commented 7 years ago

Thanks @gregorylegarec !

Just for information, we'll try to not forget to update localization keys in steps markups 😉