search

cozy / cozy-proxy

This repository was part of CozyV2 which has been deprecated - Cozy authentication and routing layer
https://blog.cozycloud.cc/post/2016/11/21/On-the-road-to-Cozy-version-3
GNU Affero General Public License v3.0
26 stars 31 forks source link

Add progression mechanism and progression indicator into views #311

Closed gregorylegarec closed 7 years ago

gregorylegarec commented 7 years ago

Will not work without #307. I tried with this PR to push a rebased version of my branch to isolate only commits related to the progression feature.

This PR adds the method getProgression(step) to Onboarding class.

It also implements the logic to get it displayed into views.

Important changes

This PR introduce a StepView "abstract" class. All step views now inherit from this class.

The markup used in views for progression indicator is the same than the proposed one in @m4dz's PR #305. So all step view templates are changing a little bit but it is absolutely not their final version.

Also added :

m4dz commented 7 years ago

@gregorylegarec can you please rebase it on development now #307 is merged in? I'll let the review be more obvious 😄

gregorylegarec commented 7 years ago

@m4dz rebased.

m4dz commented 7 years ago

Thanks! 🍿