Closed gregorylegarec closed 7 years ago
Sweet 👍
If I can have a suggestion, I'm not especially fan of separating concerns accross multiple templates, only because we need to wrap them in a <form>
tag, and I ask myself if the form shouldn't be directly put in content, to ensure readability and reassembling concerns, and the footer outside of it. We just have to reference the form
in the sumbit button using a form attribute, and everything will work like a charm 😃
@m4dz Your solution is far better, thanks for the tip !
You're welcome dude
Woohooo 🎉
Thanks @m4dz to have a review.
This PR prepare the setup of the infos onboarding step.
Every step was containing a
<form>
tag, even if it was not containing input or button. I used template inheritance and include to offer two base templates for steps.There were some incoherences with font size, width, height, etc. I made some fixes to be more compliant with @kelukeku's mockups and to mutualize code between regular steps pages and MyAccounts page.