cozy / cozy-proxy

This repository was part of CozyV2 which has been deprecated - Cozy authentication and routing layer
https://blog.cozycloud.cc/post/2016/11/21/On-the-road-to-Cozy-version-3
GNU Affero General Public License v3.0
26 stars 31 forks source link

Minor template and style improvement #349

Closed gregorylegarec closed 7 years ago

gregorylegarec commented 7 years ago

Thanks @m4dz to have a review.

This PR prepare the setup of the infos onboarding step.

m4dz commented 7 years ago

Sweet 👍

If I can have a suggestion, I'm not especially fan of separating concerns accross multiple templates, only because we need to wrap them in a <form> tag, and I ask myself if the form shouldn't be directly put in content, to ensure readability and reassembling concerns, and the footer outside of it. We just have to reference the form in the sumbit button using a form attribute, and everything will work like a charm 😃

gregorylegarec commented 7 years ago

@m4dz Your solution is far better, thanks for the tip !

m4dz commented 7 years ago

You're welcome dude

m4dz commented 7 years ago

Woohooo 🎉