cozy / cozy-settings

Settings app for Cozy Cloud
GNU Affero General Public License v3.0
4 stars 13 forks source link

fix: Change PassphraseForm's buttons types for `submit` #674

Closed Ldoppea closed 6 months ago

Ldoppea commented 6 months ago

In 3cfb9fcbda7f5f3292c88b1fc09d0b16b221e7da we migrated react/deprecated/Button to react/Buttons

Those 2 components have a different default behaviour

react/deprecated/Button would produce a button with type submit by default

react/Buttons would produce a button with type button by default

In PassphraseForm we expect the button to act as a submit as we are inside of a <form> element

As the new default type is button, the user cannot change their password anymore as the generated button would do nothing (there is no onClick instruction on it)

To fix this we want to explicitly ask for a submit type, so we rollback to the previous behaviour

Related commit: 3cfb9fcbda7f5f3292c88b1fc09d0b16b221e7da

### ✨ Features

*

### 🐛 Bug Fixes

* Fix a bug that prevented to change password from the Passphrase form

### 🔧 Tech

*
bundlemon[bot] commented 6 months ago

BundleMon

Unchanged files (16) Status | Path | Size | Limits :------------: | ------------ | :------------: | :------------: :white_check_mark: | vendors/settings.(hash).js
| 1015.96KB | - :white_check_mark: | app/settings.(hash).js
| 93.02KB | - :white_check_mark: | intents/settings.(hash).js
| 44.56KB | - :white_check_mark: | img/export-cozy-mail.(hash).svg
| 27.39KB | - :white_check_mark: | img/import-cozy.(hash).svg
| 11.09KB | - :white_check_mark: | app-settings.(hash).min.css
| 9.96KB | - :white_check_mark: | img/double_authent_prez_banner.(hash).svg
| 4.36KB | - :white_check_mark: | img/protect_data_point.(hash).svg
| 4.1KB | - :white_check_mark: | img/niv_secu_point.(hash).svg
| 1.54KB | - :white_check_mark: | intents-settings.(hash).min.css
| 1.27KB | - :white_check_mark: | img/icon-bills.(hash).svg
| 703B | - :white_check_mark: | img/icon-laptop.(hash).svg
| 439B | - :white_check_mark: | img/icon-arrow-left.(hash).svg
| 414B | - :white_check_mark: | img/icon-question-mark.(hash).svg
| 386B | - :white_check_mark: | img/icon-check.(hash).svg
| 369B | - :white_check_mark: | img/icon-phone.(hash).svg
| 343B | -

Total files change +3B 0%

Unchanged groups (3) Status | Path | Size | Limits :------------: | ------------ | :------------: | :------------: :white_check_mark: | **/*.js
| 1.13MB | - :white_check_mark: | img/*.*
| 51.07KB | - :white_check_mark: | **/*.css
| 41.84KB | -

Final result: :white_check_mark:

View report in BundleMon website ➡️


Current branch size history | Target branch size history