search

cozy / cozy-sync

webdav server for cozy
20 stars 19 forks source link

Add group support : one addressbook per contac's tags. #66

Closed jacquarg closed 9 years ago

jacquarg commented 9 years ago

In-progress ! depends on PR cozy-vcard#8 and next version of cozy-vcard.

frankrousseau commented 9 years ago

@jacquarg @aenario What is the status of this PR?

aenario commented 9 years ago

it probably works, but broke tests because we logically change the content of the vcard (adding categories). Logically, client should grab the new version and all will be well. Yet, it needs to be tested functionally and if it works, tests should be adapted for it.

frankrousseau commented 9 years ago

@jsilvestre @poupotte @clochix is there one of you who can handle it?

frankrousseau commented 9 years ago

@jacquarg Except the fact tests are failing, do you consider it as good to merge?

jacquarg commented 9 years ago

@frankrousseau : it's been a while, but yes, just a build and it will be good to merge. I am disappointed by the problems with the tests as I remember that I spend some time to enrich them and make them pass. But travis as secrects...

frankrousseau commented 9 years ago

Ok I will handle it (in fact I hope I will have enough time for it). I will include it in the work on import/export/sync of contacts.