Variants : Documentation's Radio buttons are broken in dev environment due to inverted theme displayed - Githubissues

cozy / cozy-ui

React components and CSS styles for Cozy apps

https://cozy.github.io/cozy-ui/react/

MIT License

48 stars 37 forks source link

Variants : Documentation's Radio buttons are broken in dev environment due to inverted theme displayed #1904

Open Ldoppea opened 3 years ago

Ldoppea commented 3 years ago

In dev environment, both normal and inverted themes are displayed by creating a duplicate of the normal samples.

This breaks variants' radio buttons because their name is not unique anymore and then normal samples and inverted ones share the same Radio context.

Here is a video showing the problem:

https://user-images.githubusercontent.com/1884255/133463323-f0a1a5b2-ddc2-4764-bbfa-f45e60df52b4.mp4

It is possible to counter this effect by adding a guid to those names like in this PR, but for variants this may be laborious : https://github.com/cozy/cozy-ui/pull/1902/files#diff-e640647029fda9aa6b0efe6a7c5f3ae65e65bbab85e0bc979a1aa635675681e0R66-R101

Ldoppea commented 3 years ago

cc @JF-Cozy this is a side effect of https://github.com/cozy/cozy-ui/pull/1856