search

cozy / cozy-ui

React components and CSS styles for Cozy apps
https://cozy.github.io/cozy-ui/react/
MIT License
48 stars 37 forks source link

IntentIFrame should not depend on cozy-client/withClient #2082

Open trollepierre opened 2 years ago

trollepierre commented 2 years ago

A Cozy-UI component should not know cozy-client.

We need to consume IntentIframe and provide a client in that case.

https://github.com/cozy/cozy-ui/blob/master/react/IntentIframe/IntentIframe.jsx#L105=

Crash-- commented 2 years ago

A Cozy-UI component should not know cozy-client.

Strongly disagree on that point. We've a lot of components requiring cozy-client and I think it's a good way to do what we want to do.

On the other hand, having to split cozy-ui in two, with on one side "atomic components" (and thus not depending on client) and on the other side very high level components and thus potentially depending on Client, then yes I agree to discuss