search

cozy / cozy-ui

React components and CSS styles for Cozy apps
https://cozy.github.io/cozy-ui/react/
MIT License
48 stars 37 forks source link

Font fighting on some elements #54

Closed y-lohse closed 7 years ago

y-lohse commented 7 years ago

normalize.css sets the font-familyof certain elements, for example buttons. In cozy-ui, we rely on inheritance to propagate the default font.

This means that buttons with no extra font-declaration get the default sans-serif instead of our Lato. There are actually a few places in our v3 UIs where the wrong font is used, most notably the selection bar in files.

Not sure of the best way to fix this. Should we just declare the font-family on a lot more elements in the default styles? Ping @GoOz and @m4dz for input.

GoOz commented 7 years ago

Good catch. I guess we could just force the use of Lato on buttons, select, etc using the .coz-btn class and such. As we don't really care about what looks like an unstyled element. Any thought @m4dz?

y-lohse commented 7 years ago

Well, the default coz-btn carries quite a bit of extra style with it (backgroud, paddings, etc). Again, I'm mostly thinking about the buttons in the selection bar in files (which, to be fair, could be a's instead of button's), but I'm sure there are others out there.

GoOz commented 7 years ago

Fixed in #72