Support multiple cases for the x-socialprofile field

cozy / cozy-vcard

Cozy-vcard provides vcard Parser and Objects

Other

29 stars 17 forks source link

Support multiple cases for the x-socialprofile field #15

Closed mizrachiran closed 9 years ago

mizrachiran commented 9 years ago

Support multiple cases, observed on iOS, for the x-socialprofile field. In the previous implementation, when the charset is presented I was getting type=utf & value=facebook. This implementation support both types.

The following variations were checked: X-SOCIALPROFILE;type=facebook;x-user=lee.nadel;x-userid=807274769;x-displayname=Lee Nadel:http://www.facebook.com/lee.nadel X-SOCIALPROFILE;CHARSET=UTF-8;TYPE=facebook:barak.bukshpan X-SOCIALPROFILE;TYPE=facebook:barak.bukshpan

frankrousseau commented 9 years ago

Hi @mizrachiran,

Thank you for the fix. Can you add a test for your use case?

mizrachiran commented 9 years ago

Hi @frankrousseau I added unittest to validate the 3 different cases I observed. Let me know if anything else is needed.

Thanks!

frankrousseau commented 9 years ago

Awesmone. Thank you!

frankrousseau commented 9 years ago

Published as 0.2.13