cozy / create-cozy-app

A CLI to bootstrap a "zero-configuration" application for the Cozy V3 platform
https://docs.cozy.io/en/tutorials/app/
MIT License
16 stars 15 forks source link

fix(dedupe): resolve manually material-ui inside node-modules #1470

Closed trollepierre closed 1 year ago

trollepierre commented 2 years ago

Since cozy-ui will be adding MUI as direct dependency,

MUI risks to be duplicated, that's why we handle the dedupe

trollepierre commented 2 years ago

Comment out-of-scope:

Apparently react-is is already dedupe in CCA. I am wondering if we should set it directly as dedupe.

Capture d’écran 2022-07-21 à 17 57 41

I will check no interest in bundle size reduction, apparently

Bundle without:

Capture d’écran 2022-07-21 à 17 59 53

bundle with:

Capture d’écran 2022-07-21 à 18 34 59
trollepierre commented 2 years ago

@Crash-- or @acezard : what should I do with this PR?