search

cozyazure / leaflet-overlay

An experimental project to overlay an image on leaflet and interact with it
0 stars 0 forks source link

Upon Upload of Image - Appropriately Sized Image Appears (e.g. x% of current window size etc.) #10

Open traverseAI opened 7 years ago

traverseAI commented 7 years ago

Should not follow the original pixel size of image.

cozyazure commented 7 years ago

But how should we determine the value of x?

traverseAI commented 7 years ago

Till it "looks good". I think 1/6 or a bit more of the map window seems about right.

On Wed, Dec 28, 2016 at 6:53 PM, Joshua Foo Fang Hau < notifications@github.com> wrote:

But how should we determine the value of x?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cozyazure/leaflet-overlay/issues/10#issuecomment-269460815, or mute the thread https://github.com/notifications/unsubscribe-auth/AXXv1V3FaK_9J_q-4-pfbIDE1nb5SHugks5rMj-bgaJpZM4LWyyY .

cozyazure commented 7 years ago

So, regardless of zoom level, and regardless of the dimension, we always shrink it to 1/6 of the window of the browser?

traverseAI commented 7 years ago

Yes. 1/6 is assuming it is a vertical image but it may not be. So we can just play around with some numbers.

The intent is that of the "overlay". If you think about powerpoint for example, you load a 6000 pixel image, you have to zoom all the way out and resize the image.

Thet

On Wed, Dec 28, 2016 at 6:59 PM, Joshua Foo Fang Hau < notifications@github.com> wrote:

So, regardless of zoom level, and regardless of the dimension, we always shrink it to 1/6 of the window of the browser?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cozyazure/leaflet-overlay/issues/10#issuecomment-269461561, or mute the thread https://github.com/notifications/unsubscribe-auth/AXXv1RhIx-l2zx6ETF-A7PMDaT-XnBnWks5rMkEsgaJpZM4LWyyY .

cozyazure commented 7 years ago

Okay I will think of a more intuitive way of doing this.