search

cozybit / wpa_s_mesh_android

Other
2 stars 1 forks source link

driver_nl80211.c: Review if-else statement #13

Closed jlopex closed 10 years ago

jlopex commented 10 years ago 
  if (flags & NL80211_FEATURE_SK_TX_STATUS)
          info->data_tx_status = 1;
  • else
  • info->data_tx_status = 1;

... odd...

bcopeland commented 10 years ago

There's this which gives some rationale, I think -- https://github.com/cozybit/wpa_s_mesh_android/issues/1

jcard0na commented 10 years ago

Oh, wow. Yes, that should have been a comment in the code. Thanks for pointing that out.

silverjam commented 10 years ago

Should this code at least say "else if this is a mesh interface"?

On Mon, Mar 24, 2014 at 4:08 PM, jcard0na notifications@github.com wrote:

Oh, wow. Yes, that should have been a comment in the code. Thanks for pointing that out.

Reply to this email directly or view it on GitHubhttps://github.com/cozybit/wpa_s_mesh_android/issues/13#issuecomment-38512919 .

bcopeland commented 10 years ago

On Mon, Mar 24, 2014 at 04:16:09PM -0700, Jason Mobarak wrote:

Should this code at least say "else if this is a mesh interface"?

Seems like this shouldn't go upstream since it's to work around some Android crud... but probably worth keeping around locally until a solution is found.

jcard0na commented 10 years ago

Ok, marked explicitly as a workaround in commit 05a6a1bfd0fa41419bb4070ace82ad7a05812c70