search

cozybit / wpa_s_mesh_android

Other
2 stars 1 forks source link

driver_nl80211.c: Review action frame registration #15

Closed jlopex closed 10 years ago

jlopex commented 10 years ago

+

  • /* Mesh peering open */
  • if (nl80211_register_action_frame(bss, (u8 *) "\x0f\x01", 2) < 0)
  • ret = -1;
  • /* Mesh peering confirm */
  • if (nl80211_register_action_frame(bss, (u8 *) "\x0f\x02", 2) < 0)
  • ret = -1;
  • /* Mesh peering close */
  • if (nl80211_register_action_frame(bss, (u8 *) "\x0f\x03", 2) < 0)
  • ret = -1;

ISTR there's a way you can register for all of them at once, maybe

nl80211_register_action_frame(bss, "\x0f", 1)
jcard0na commented 10 years ago

The suggested approach would register for all Self-Protected frames. Currently they are only mesh frames, but it may not be so in the future. Also it would register reserved frames and frames that we don't handle yet (Mesh Group Key Inform, Mesh Group Key Acknowledge). So better to keep the individual frame registrations.