search

cozybit / wpa_supplicant-o11s-legacy

wpa_supplicant
Other
6 stars 10 forks source link

mesh: Fix stray pointer dereferencing on deinit procedure #18

Closed masap closed 10 years ago

masap commented 10 years ago

mesh_mpm_send_plink_action() uses ifmsh->mconf. But when mesh_mpm_send_plink_action() called via wpa_supplicant_mesh_iface_deinit(), the pointer is already freed by wpa_supplicant_mesh_iface_deinit().

bcopeland commented 10 years ago

On Tue, Jul 08, 2014 at 08:03:59PM -0700, Masashi Honma wrote:

mesh_mpm_send_plink_action() uses ifmsh->mconf. But when mesh_mpm_send_plink_action() called via wpa_supplicant_mesh_iface_deinit(), the pointer is already freed by wpa_supplicant_mesh_iface_deinit().

Hi Masashi,

Thanks for the patch, but, maybe it would be better to work off of the prepare-submit-v9 branch? This is what is going to be submitted to hostapd in the next few weeks.

I think this one is already fixed there, please correct me if wrong.

Bob Copeland %% www.bobcopeland.com

masap commented 10 years ago

Hello Bob,

Thanks for a comment.

I'm already working on the prepare-submit-v9 branch. So this bug exists on the prepare-submit-v9 branch.

I found this bug with the tool valgrind http://valgrind.org/.

Couldn't you reproduce this bug on your environment ?

bcopeland commented 10 years ago

Sorry for the noise, I missed that in the pull request.