cozydev-pink / protosearch

prototype search library in pure scala
https://cozydev-pink.github.io/protosearch/
Apache License 2.0
9 stars 6 forks source link

Add support for Regex queries #35

Closed valencik closed 5 months ago

valencik commented 1 year ago

Add in Lucille https://github.com/cozydev-pink/lucille/pull/21

I think we can take the regex string value, build a regex and iterate through the terms array collecting matches. This obviously won't be particularly efficient, but it's probably fast enough for now. (And storing an FSA in the index like Lucene does is just too complicated for now)

VigneshSK17 commented 6 months ago

Hi @valencik, I am a beginner to the world of open-source contribution and wanted to get started by contributing to this issue. I found out about protosearch through Google Summer of Code and found the scaladoc search project interest. I hope you can guide me through the PR process, as I have implemented what I believe is Regex query support in the forked branch referenced above.

valencik commented 6 months ago

Hey @VigneshSK17, thanks so much for your interest and contribution!

Heads up: I have possibly just created some merge conflicts for you by merging a new PR that touches some of the same areas you've changed. Hopefully you can merge latest main into your work without too much trouble. But let me know if you need a hand.

Some thoughts on your approach here:

Let me know if you have any questions. And feel free to open a PR now and we can continue discussion there. :)

VigneshSK17 commented 6 months ago

I created a PR #188 and will work on fixing the merge conflicts and your suggestions!