search

cp2004 / OctoPrint-GCodeMacros

Configure custom gcode macros you can use anywhere!
https://plugins.octoprint.org/plugins/gcode_macro
GNU Affero General Public License v3.0
7 stars 2 forks source link

Changes Breaking Other Plugin's @Commands? #10

Closed jneilliii closed 2 years ago

jneilliii commented 2 years ago

The lines here seem to indicate that you are manipulating the gcode and removing the @ command from the command being passed to the printer, and through other plugin hooks. Should either not change the command or add the @ character back in?

Bug reported https://github.com/jneilliii/OctoPrint-BedLevelVisualizer/issues/555#issuecomment-1179842756

cp2004 commented 2 years ago

Thanks... I didn't test this for the latest bugfix release, but I'm sure it did work at some point so I will try and find how I managed to break it.

cp2004 commented 2 years ago

Ah - it was probably https://github.com/cp2004/OctoPrint-GCodeMacros/commit/a8d81d98a71c204c71d4f9a7e781d37471c1bd0f, which was never actually released in 1.1.1, but then when I pushed 1.1.2 it came with it and ended up breaking things maybe?

jneilliii commented 2 years ago

Yeah, returning an empty list there is the same as returning the command coming in IIRC, so that would definitely cause this. You can either revert that return [command] back to just return or return [] and should have the same effect as the PR I submitted.